Fix dot general flop counting

[Aaraviitkgp]

Fixed cost_estimate.py to correctly accumulate contracting sizes
Added regression test for multiple contracting dimensions
Updated BUILD file to include new test

Fixes #33388

[gemini-code-assist]

Summary of Changes

Hello @Aaraviitkgp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the Pallas cost estimation module where the FLOP count for dot_general operations was miscalculated, particularly when multiple contracting dimensions were involved. The fix ensures that the contracting dimensions are correctly accumulated before applying the FLOP multiplier, leading to accurate cost estimates. To prevent future regressions, a dedicated test case has been added to verify the corrected behavior.

Highlights

• FLOP Counting Correction: The dot_general_cost_rule in cost_estimate.py has been updated to accurately calculate floating-point operations (FLOPs) for dot_general operations, specifically addressing an issue where FLOPs were incorrectly accumulated across multiple contracting dimensions.
• Regression Test Added: A new regression test, test_dot_general_multiple_contracting_dims, has been introduced to validate the fix and ensure correct FLOP counting for operations with multiple contracting dimensions, directly addressing issue dot_general_cost_rule incorrect for multiple contracting dims #33388.
• Build System Update: The BUILD file was modified to include the newly added test file, cost_estimate_test.py, ensuring it is part of the test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the FLOP counting for dot_general operations with multiple contracting dimensions. The logic is now sound, and a regression test has been added to prevent this issue from recurring. My review includes a minor style suggestion and points out a duplicated test file that should be cleaned up.