Skip to content

Conversation

@Prakharprasun
Copy link

Added missing documentation for out_sharding in lax.conv_general_dilated

The parameter out_sharding was present in the function signature but missing its description in the docstring

The added documentation covers the parameter's info.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Prakharprasun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a documentation gap by providing a comprehensive explanation for the out_sharding parameter in the lax.conv_general_dilated function. This enhancement improves clarity for users, especially those working with multi-device computations and explicit sharding, by detailing how output arrays are sharded across devices.

Highlights

  • Documentation Update: Added a detailed description for the out_sharding parameter within the lax.conv_general_dilated function's docstring, clarifying its role in multi-device computation and explicit sharding.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the missing documentation for the out_sharding parameter in lax.conv_general_dilated. The added docstring is helpful. I've suggested a small revision to make it more concise and to clarify the behavior when out_sharding is not specified, which will make it more complete for users.

Can be a :class:`~jax.sharding.NamedSharding`, a
:class:`~jax.sharding.PartitionSpec` (``P``), or ``None`` (default).
If unspecified, the sharding is inferred from the inputs where possible,
otherwise an error is raised. Primarily used in explicit sharding mode.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the explicit sharding doc: https://docs.jax.dev/en/latest/notebooks/explicit-sharding.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion!

I've added it as:
“... See the explicit sharding tutorial <https://docs.jax.dev/en/latest/notebooks/explicit-sharding.html>_ for more details. “

I would be happy to refine further based on your suggestions.

@Prakharprasun Prakharprasun force-pushed the doc/add-out-sharding-conv-general-dilated branch from a94be04 to 7dec320 Compare November 24, 2025 16:52
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Nov 24, 2025
@yashk2810
Copy link
Collaborator

Can you squash please?

…l_dilated The parameter `out_sharding` was present in the function signature but missing its description. This commit adds the complete documentation, including details on inference behavior and a link to the explicit sharding tutorial.
@Prakharprasun Prakharprasun force-pushed the doc/add-out-sharding-conv-general-dilated branch from 7dec320 to 3ac23b5 Compare November 24, 2025 17:55
@Prakharprasun
Copy link
Author

Can you squash please?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run pull ready Ready for copybara import and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants