Add out_sharding argument to dot_product_attention #33505
+56
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many operations like
dotandconvhave anout_shardingargument to reconcile incompatible arguments when using explicit sharding. Currently,dot_product attentionlacks such an argument.Ambiguity about the out_sharding location only occurs in binary operations. Dot product attention has three of them: the$QK^T$ multiplication, the addition of the bias term, and the multiplication by $V$ . However, there will be substantial overlap in the output shardings of these intermediate values. Given an additional
s_shardingargument, everything is identifiable.