Add a flag to let the update thread to exit when plugin is unloaded#340
Open
Sniffleupagus wants to merge 1 commit intojayofelony:noaifrom
Open
Add a flag to let the update thread to exit when plugin is unloaded#340Sniffleupagus wants to merge 1 commit intojayofelony:noaifrom
Sniffleupagus wants to merge 1 commit intojayofelony:noaifrom
Conversation
Signed-off-by: Sniffleupagus <129890632+Sniffleupagus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update_value thread does not exit when the plugin is disabled. it sticks around until pwnagotchi exits.
Description
I added a boolean "keep_going = True" to the PisugarServer. In update_value, I changed "while true:" to "while keep_going:". Then in on_unload, keep_going it set False. The background thread will exit the next time it starts the loop.
Motivation and Context
Threads would accumulate when pisugarx is disabled/enabled.
How Has This Been Tested?
Tested on pwnagotchi 2.9.5-3.
Types of changes
Checklist:
git commit -s