Fix deprecated index_together for django 5.1 #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvynl
reviewed
Sep 25, 2024
clickhouse_backend/backend/schema.py
Outdated
| if ( | ||
| any(field.db_index for field in model._meta.local_fields) | ||
| or model._meta.index_together | ||
| or any(len(index.fields) > 1 for index in model._meta.indexes) |
There was a problem hiding this comment.
Explicitly defined indexes are allowed, you don't need to check model._meta.indexes.
Change this to or getattr(model._meta, "index_together", None) and delete line 220-223
dishn
force-pushed
the
fix-index-together
branch
from
d67ab51 to
d3b39a4
Compare
dishn
force-pushed
the
fix-index-together
branch
from
d3b39a4 to
7ab46d6
Compare
jayvynl
approved these changes
Sep 25, 2024
|
@jayvynl Do the failed tests require any of my work? |
|
I will fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 5.1 removes
index_togetherfromModel.Metaand there exist a condition inschema.pythat usesindex_together. This pr aims to fix the deprecation and keep it compatible with prior django versions as well