Skip to content

refactor base merge tree engine to check Iterable value #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2025
Merged

refactor base merge tree engine to check Iterable value #111

merged 4 commits into from
Jan 10, 2025

Conversation

RuslanSibgatulin
Copy link
Contributor

No description provided.

@RuslanSibgatulin RuslanSibgatulin mentioned this pull request Dec 17, 2024
Closed
@jayvynl
Copy link
Owner

jayvynl commented Dec 26, 2024

Thank you. But there are more is_iterable to be replaced. Just search all source code files for is_iterable.

@jayvynl
Copy link
Owner

jayvynl commented Dec 30, 2024 •
edited
Loading

Thank you very much. But there are 2 more things:

  1. could you please format the code:
tox -e format
# or
isort clickhouse_backend example tests
  1. Write changelog.

@jayvynl jayvynl merged commit 493caa4 into jayvynl:main Jan 10, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuslanSibgatulin @jayvynl