Fix for simultaneous queries issue when iterating #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitriona-cloudsmith
force-pushed
the
main
branch
from
58de813 to
552a483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If iterating over a Django queryset and iteration is broken for any reason, the connection will stay alive and be re-added to the connection pool. Upon issuing another query to Clickhouse, a
PartiallyConsumedQueryErroris thrown. This is raised here in the Clickhouse driver.Commit
562a7e5b1948b1483386c7239c5d480e27d389cddemonstrates the problematic behaviour here.This PR adds a check to the connection for
is_query_executing. If this is true, the connection is not re-added to the pool and is instead disconnected.