Skip to content

Fixing replica query when cluster is default #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

Fixing replica query when cluster is default #139

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47ea049
Fixing replica query when cluster is default
rcampos87 Oct 12, 2025
4d6c178
change log
rcampos87 Oct 12, 2025
11fad78
fixes
rcampos87 Oct 20, 2025
07339a1
lint
rcampos87 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
### 1.5.0
- feat: #139: Fix to replicas query when using default as cluster name
- feat: #133: Fix simultaneous queries error when iteration is interrupted
- feat: #130: Add `distributed_migrations` database setting to support distributed migration queries.
- feat: #129: Add `toYearWeek` datetime functionality
Expand Down
2 changes: 1 addition & 1 deletion clickhouse_backend/patch/migrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _check_replicas(connection):

with connection.cursor() as cursor:
cursor.execute(
f"select replica_num from system.clusters where cluster={connection.migration_cluster}"
f"select replica_num from system.clusters where cluster='{connection.migration_cluster}'"
)
(replica_count,) = cursor.fetchone()
return replica_count >= 1
Expand Down