Add pre-commit with ruff #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvynl
reviewed
Oct 21, 2025
Contributor
Author
|
@jayvynl will still modify gh actions to run dependently on outcome of pre-commit, not to start tests if linting failed. tbh flake8 is not necessary either. |
rcampos87
force-pushed
the
feature/pre-commit
branch
from
5e6850a to
ef7a16a
Compare
Contributor
Author
|
Ok changed, tests only run after linting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation for this PR is to make contributing easier. Other benefits are that running ruff is much faster than black and pre-commit hooks can easily be updated.