Richer alerts; improved docs; easier testing #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 2, 2023 14:43
We only need the src folder in the build container, not all the other cruft.
New logging module with configurable log level.
Alerts now: - link to the alertmanager URL and a dashboard if env vars are configured. - all labels other than explicitly formatted labels are included in the alert output - when annotation.url is set the link will be included in the alert - fixed extra spaces that broke the alert link - emit the alert severity instead of "firing" when available
jelmer
reviewed
Oct 10, 2023
Contributor
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
FWIW these all seem like sensible improvements to me. They're orthogonal though, each commit could be it's own PR and be merged independently.
Co-authored-by: Jelmer Vernooij <jelmer.vernooij@aiven.io>
Author
|
@jelmer - yes - I intentionally make commits each with their own goal - so you're right they could be their own PRs. If you merge without squashing they will continue to be discrete changes in the history. As they're all applied on my forked master branch - I guess the alternative would be to cherry pick each commit into it's own branch and raise multiple PRs - but the end result would be the same. |
Contributor
|
@jinnko makes sense - FWIM I'm not a committer to matrix-alertmanager, just an interested contributor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may not want to merge this, but thought I'd share just in case.
From the individual commit message:
configured.
alert output