optionally use select_related to pull related fields for old#415
Draft
dgravitate wants to merge 3 commits intojazzband:masterfrom
Draft
optionally use select_related to pull related fields for old#415dgravitate wants to merge 3 commits intojazzband:masterfrom
old#415dgravitate wants to merge 3 commits intojazzband:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
- Coverage 91.79% 91.01% -0.78%
==========================================
Files 23 23
Lines 646 657 +11
==========================================
+ Hits 593 598 +5
- Misses 53 59 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Thanks @dgravitate for the patch 👍 I haven't looked in detail at the patch. but you need:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to use select_related to pull related fields when getting the old instance to compare against. This should eliminate some unnecessary queries and boost performance, particularly when dealing with lots of related fields.