-
Notifications
You must be signed in to change notification settings - Fork 428
Add sample project for django-auditlog testing #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add Django project configuration (settings, urls, wsgi, asgi) - Add demo app with basic structure - Add requirements.txt with Django and auditlog dependencies - Add management script for running the sample project
- Add Post, Category, Tag models demonstrating various field types
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 33 33
Lines 1144 1144
=======================================
Hits 1096 1096
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks @2ykwang for this PR. Not sure we want to include this project in the code base because we need to take care of the code. I'm afraid the code becomes out of date at some point because we don't have a test for the code. |
Thanks feedback! @hramezani is the demo project unnecessary, or would you consider merging it if we establish a maintenance plan? Including a demo helps users and maintainers verify features quickly, and many popular OSS projects use a top-level examples/ or tutorial/ directory so with a clear update strategy, it should be fine. |
Having the demo project is good. We need to keep the project updated and make sure that it doesn't break. So, I am mostly worry about the maintenance |
That makes sense. I’ll this PR to a draft for now and I’ll review the maintenance plan for the demo project and check if it’s really necessary, then update it again! |
Add a sample Django project for testing auditlog functionality.
Makes it easier for developers to quickly test auditlog behavior and reproduce issues.
(based on my testing setup - feedback appreciated!)