Skip to content

Close files in create thumbnail#252

Merged
johanneswilm merged 4 commits intojazzband:mainfrom
satya-waylit:close-files-in-create_thumbnail
Jan 7, 2026
Merged

Close files in create thumbnail#252
johanneswilm merged 4 commits intojazzband:mainfrom
satya-waylit:close-files-in-create_thumbnail

Conversation

@satya-waylit
Copy link
Contributor

@satya-waylit satya-waylit commented Dec 14, 2025

Use contextlib.closing to close the orig file in Avatar.create_thumbnail method.

Fixes #244

@johanneswilm
Copy link
Member

@satya-waylit Thanks for this. I see some tests failing. Do you know what this is about?

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.60%. Comparing base (4955d2d) to head (73d1853).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
avatar/models.py 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   64.34%   64.60%   +0.25%     
==========================================
  Files          21       21              
  Lines         906      907       +1     
==========================================
+ Hits          583      586       +3     
+ Misses        323      321       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johanneswilm johanneswilm merged commit 80a7c95 into jazzband:main Jan 7, 2026
15 checks passed
@satya-waylit
Copy link
Contributor Author

@johanneswilm Thanks for merging. Looks like you got the test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResourceWarning: unclosed file in create_thumbnail

2 participants