Skip to content

Comments

Run ruff format#641

Merged
Natim merged 2 commits intomasterfrom
chore/run-black
Oct 7, 2025
Merged

Run ruff format#641
Natim merged 2 commits intomasterfrom
chore/run-black

Conversation

@Natim
Copy link
Contributor

@Natim Natim commented Oct 7, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 86.48649% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.82%. Comparing base (c89ee7c) to head (6d01cff).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
constance/forms.py 69.23% 3 Missing and 1 partial ⚠️
constance/checks.py 33.33% 1 Missing and 1 partial ⚠️
constance/management/commands/constance.py 90.47% 2 Missing ⚠️
...onstance/migrations/0002_migrate_from_old_table.py 66.66% 2 Missing ⚠️
constance/admin.py 96.00% 1 Missing ⚠️
constance/backends/redisd.py 50.00% 1 Missing ⚠️
constance/codecs.py 95.45% 1 Missing ⚠️
constance/migrations/0003_drop_pickle.py 66.66% 1 Missing ⚠️
constance/test/unittest.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          21       21           
  Lines         751      751           
  Branches      122      122           
=======================================
  Hits          637      637           
  Misses         82       82           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

indent-width = 4

[tool.ruff.format]
quote-style = "single"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#560 (comment)

Do we really need to change style?

Copy link
Contributor Author

@Natim Natim Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd to enforce single quotes while the Python community is using double quotes everywhere else, doesn't it? Also PEP8 agrees to both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer ", but I can use anything; only consistency matters.
In a previous attempt, I reverted this style to avoid changing hundreds of lines only because of a quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reminding me of the discussion, I believe one year later we can do the change since we both agree on this.

@Natim Natim merged commit c6b2c44 into master Oct 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants