Improve performance when using condition_dict #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudep
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Uses a bit of caching to reduce the number of calls needed when using condition_dict.
For us, this reduces the number of queries in one view (for each step of that view) from nearly 300 to around 17. It's possible it could be improved further but I think this is a dramatic enough of an improvement to be useful on its own.
All the tests pass and I checked my wizards were all working locally. I went for a slightly more realistic test rather than a minimal test, but I can change this if desired.
A simpler solution is to cache the
allproperty. It works quite well, but there are still some extra queries when doing this.