Use ModelAdmin.opts for correct reverse in admin

[frennkie]

Make sure to use ModelAdmin.opts in admin.py in order to get the correct app_label and model_name. This is important when a subclass (e.g. of Newsletter) is used.

[coveralls]

Coverage decreased (-0.06%) to 88.327% when pulling ebc42b9 on frennkie:fix-hardcoded-admin-links into 57ac58d on dokterbob:master.

[coveralls]

Coverage decreased (-0.07%) to 88.317% when pulling 637dddb on frennkie:fix-hardcoded-admin-links into 57ac58d on dokterbob:master.

[dokterbob]

Hi @frennkie,

Thanks for the contrib! I'm sure this is useful and the code seems ready to merge as it is. However, as I am not currently aware of this pattern, I would assume there are a fair amount of fellow developers who aren't.

Could I ask you to provide some reference, either here (so I'll add it to the commit msg) or as a comment to the code, of either the relevant section in the Django doc's, or perhaps another place where this is documented? If not, would it be possible to add a ~ one sentence rationale explaining the behaviour in addition to the objective (which you already did)?

This is all just to facilitate future contribution, as well as the overall didactic quality of the code.

[frennkie]

I removed one commit that was actually not directly related and two changes that might be (a bit) disputable.

Now all this does is use ModelAdmin.opts.app_label and ModelAdmin.opts.model_name instead of hard-coding the label and name.

I have to admit that "my heart isn't into this so much anymore".. ;-D

The reason I started this was that I wanted to subclass some a class which proved to be really hard. I ended up using a ProxyModel instead only overriding the methods that I needed to change in my project (most prominently Submission.send_message) - which is looking fine so far.