-
-
Notifications
You must be signed in to change notification settings - Fork 629
Update the 'pipsupported' version to 25.2 #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3aca9ab
to
7f91916
Compare
Do we have pip unpinned in RTD / Sphinx land? |
By the way, there was talk about rephrasing the tox factors. I think @hugovk mentioned it being confusing.. But that would be a separate PR, of course. |
Yeah, it looks like it. I'm surprised by it, but I'll take a look. Maybe just fold it into this fix, since it's "also pinning |
Oh.. RTD is still configured with their control. Could you convert it to use this config instead https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/27bdb93/.readthedocs.yaml, in a separate PR? This also requires a small change in tox: https://github.com/ansible/awx-plugins/blob/c4180cd/tox.ini#L373-L394 |
I bet the GHA job doesn't fail only because the wheels are cached and the installer doesn't bother to look for newer ones. Looking at |
@@ -0,0 +1 @@ | |||
`pip-tools` now tests on and officially supports `pip` version 25.2 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: I think a byline may be missing here? (noticed during preparation of #2217)
`pip-tools` now tests on and officially supports `pip` version 25.2 . | |
`pip-tools` now tests on and officially supports `pip` version 25.2 . | |
-- by {user}`sirosen` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, it's not mandatory. But yes, it could be added if Stephen wants. Another bit that caught my eye is a stray whitespace before the trailing period..
Note that if byline is standalone, it doesn't need a leading whitespace.
@@ -0,0 +1 @@ | |||
`pip-tools` now tests on and officially supports `pip` version 25.2 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could avoid the padding space by applying some rephrasing:
`pip-tools` now tests on and officially supports `pip` version 25.2 . | |
`pip-tools` now tests on and officially supports version 25.2 of `pip`. |
(I don't like placing decimal-point-delimited version numbers next to a full-stop, either)
Update the 'pipsupported' build, now that there's a new release.
Contributor checklist
changelog.d/
(seechangelog.d/README.md
for instructions) or the PR text says "no changelog needed".Maintainer checklist
skip-changelog
label.