Fix: Ensure that cache directory exists

[koppor]

With 94850ed, we get

type 'dev.jbang.gradle.tasks.JBangTask' property 'installDir' specifies directory '/home/runner/.gradle/caches/jbang' which doesn't exist.

A simple createDirectories should do the trick, doesn't it?

[aalmiray]

Please reword the commit message using conventional commits.

[koppor]

@Siedlerchr worked on this. Instead of using .gradle, .jbang/cache is used. Is this OK?

[aalmiray]

Why change the value?

[koppor]

Why change the value?

We had an internal discussion. Was not intended.

I updated - force push to keep one commit with conventual commit message.

[Siedlerchr]

The thing we needed to change is the access to "project." in the constructor. This breaks the configuration cache and is not allowed. But with this fixes the plugin works now at JabRef

[koppor]

Maybe related:

 JBang not found. Checking cached version latest
Downloading https://www.jbang.dev/releases/latest/download/version.txt
100%
JBang not found. Downloading version 0.135.1
Downloading https://github.com/jbangdev/jbang/releases/download/v0.135.1/jbang-0.135.1.zip
10%.20%.30%.40%.50%.60%.70%.80%.90%.100%
The process cannot access the file because it is being used by another process.


> Task :jablib:generateLtwaListMV
Caching disabled for task ':jablib:generateLtwaListMV' because:
  Caching has not been enabled for the task
Task ':jablib:generateLtwaListMV' is not up-to-date because:
  No history is available.
Found JBang v.0.135.1

Executing JBang command: jbang.cmd run D:\a\jabref\jabref\build-support\src\main\java\LtwaListMvGenerator.java
The process cannot access the file because it is being used by another process.

C:\Users\runneradmin\.jbang\cache\27838.jbang.tmp

[aalmiray]

Oh gees. Windows is the gift that keeps on giving.

[Siedlerchr]

A rerun helped here

[aalmiray]

Is this a problem on Windows at all?

[koppor]

Is this a problem on Windows at all?

Maybe not related to this PR. We try to download jbang before.

It is only an issue for users having

• multiple independent JBang tasks
• org.gradle.parallel=true activated

[koppor]

@aalmiray We think our patch works. Would it be possible to include it in main and craft a release? Currently we test with a jitpack variant which introduces another variable.

[Siedlerchr]

The latest change (making the property internal) now ensure that it also works inside docker based environment.

[koppor]

The latest change (making the property internal) now ensure that it also works inside docker based environment.

Build says:

 Caused by: org.gradle.internal.execution.WorkValidationException: Plugin validation failed with 1 problem:
  - Error: Type 'dev.jbang.gradle.tasks.JBangTask' property 'installDir' annotated with @Internal should not be also annotated with @InputDirectory.

[koppor]

I am not sure how we can make the install directory configurable with a default value based on the gradle directory layout.

Changing it to @Internal doesn't seem to allow @Input or @InputDirectory., but it "magically" fixes running on gradle's docker image (https://hub.docker.com/_/gradle)

[Siedlerchr]

@koppor Fixed now. As far as I understand, this internal still allows you to change the value, but it will not be considered for out of date checks which is okay because the other properties are annoated as input.

[koppor]

Then, we accept that changing JBang installations (e.g., down/upgrading versions) don't trigger a rebuild. -- Could be OK, because it is a seldom use case to switch between JBang installations.

[koppor]

Discussion result: This is only the cache directory. the input version matters. This really triggers the change of the version.

Thus, I am also fine with the latest update and vote for merge and a release 😅.