Skip to content

Conversation

@maxandersen
Copy link
Collaborator

This is mainly to see if removal of the 6+ year old sideffect found in #2341 actually breaks any tests.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the environment variable prefix used to override directives in jbang scripts from JBANG_ to JBANG_APP_, addressing a 6+ year old naming collision issue. The change prevents accidental side effects where the JBANG_JAVA_OPTIONS environment variable (used by the jbang launcher script) would inadvertently override script directives.

Key Changes:

  • Modified collectDirective() method to use JBANG_APP_ prefix instead of JBANG_ for directive environment variable overrides
  • This affects directives like JAVA_OPTIONS, COMPILE_OPTIONS, RUNTIME_OPTIONS, etc.
  • Breaking change: existing scripts relying on JBANG_<directive> env vars will need to switch to JBANG_APP_<directive>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@maxandersen maxandersen changed the title fix: use JBANG_DIRECTIVES_* rather than JBANG_* for env config fix: use JBANG_APP_* rather than JBANG_* for env config Nov 28, 2025
@maxandersen maxandersen merged commit 85562e3 into jbangdev:main Nov 29, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant