Skip to content

Feature/accessibility for selactable row #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/accessibility for selactable row #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b90544a
Update TableColCheckbox.tsx
sudhansurana Aug 5, 2025
6034977
Update TableCellCheckbox.tsx
sudhansurana Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DataTable/TableCellCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function TableCellCheckbox<T>({
};

return (
<TableCellCheckboxStyle onClick={(e: React.MouseEvent) => e.stopPropagation()} className="rdt_TableCell" $noPadding>
<TableCellCheckboxStyle onClick={(e: React.MouseEvent) => e.stopPropagation()} className="rdt_TableCell" role="cell" $noPadding>
<Checkbox
name={name}
component={selectableRowsComponent}
Expand Down
2 changes: 1 addition & 1 deletion src/DataTable/TableColCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function ColumnCheckbox<T>({
};

return (
<ColumnStyle className="rdt_TableCol" $headCell={headCell} $noPadding>
<ColumnStyle className="rdt_TableCol" $headCell={headCell} role="columnheader" $noPadding>
<Checkbox
name="select-all-rows"
component={selectableRowsComponent}
Expand Down