Add opentelemetry dependency and configuration#256
Add opentelemetry dependency and configuration#256marcosgopen wants to merge 3 commits intojbosstm:mainfrom
Conversation
|
I have ran it locally and what I found so far does work for exposing the metrics. It will be good to reach agreement on issue #255 as to the type of data we might want to export or maybe we go ahead with this one and refine that later. |
|
If possible, it would be good to have a unit test, I tested it manually. |
pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-observability-devservices-lgtm</artifactId> |
There was a problem hiding this comment.
well, TBH, I think if I will need to test this in dev mode, I can add. Otherwise this will just eat up startup time of dev mode so I would remove it and just add a comment that if you want, you can add this dependency.
There was a problem hiding this comment.
Thanks, I removed it from the pom and added in the readme.
Good point, I have just added a unit test. |
marcosgopen
force-pushed
the
opentelemetry
branch
from
a61b65f to
4e1ebfe
Compare
3 participants
addresses #255
I am adding the opentelementry dependency with prometheus and grafana to visualize the prometheus info in dev mode.