Skip to content

Testing update#262

Merged
marcosgopen merged 3 commits intojbosstm:mainfrom
marcosgopen:testing-upgrade
Feb 18, 2026
Merged

Testing update#262
marcosgopen merged 3 commits intojbosstm:mainfrom
marcosgopen:testing-upgrade

Conversation

@marcosgopen
Copy link
Member

@marcosgopen marcosgopen commented Feb 16, 2026

Re enable quarkus and tck testing which were skipped

@tomjenkinson
Copy link
Member

tomjenkinson commented Feb 17, 2026

@marcosgopen - please can I ask you to draw my attention to where the testing was re-enabled in the changes?

@marcosgopen
Copy link
Member Author

marcosgopen commented Feb 18, 2026

quarkus tests and tck tests were skipped because of configuration issues.
You can verify it in the log of jobs (before [https://github.com/jbosstm/lra/actions/workflows/lra-profile.yml] it took 20 minutes and now around 30 minutes [https://github.com/jbosstm/lra/actions/runs/22059554095]).
Having a look at the old log you can find

[INFO] --- failsafe:3.5.4:integration-test (default) @ lra-test-tck ---
...
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

that is because the tck needs the junit-engine-vintage as microprofile-lra-tck uses junit 4 and we have junit 6 (that is why tests were skipped).
In this PR's checks you can see instead:

[INFO] --- failsafe:3.5.4:integration-test (default) @ lra-test-tck ---
....
[INFO] Tests run: 133, Failures: 0, Errors: 0, Skipped: 0

@marcosgopen
Copy link
Member Author

marcosgopen commented Feb 18, 2026 •
edited
Loading

Concerning quarkus tests:
Before the tests were not executed, now you can see:

"[INFO] --- failsafe:3.5.4:integration-test (default) @ lra-test-quarkus-context-test ---"
...
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

There was a problem in the failsafe plugin configuration. The error was introduced when I removed the parent pom of the lra-test-quarkus project (as the configuration was not inherited anymore). Adding the parent pom again fixes the issue.

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/crash/pom.xml
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-test-arquillian-extension</artifactId>
<scope>test</scope>
<exclusions>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean and refactor

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/quarkus/context/test/pom.xml
<dependency>
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-test-arquillian-extension</artifactId>
<scope>test</scope>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sortpom

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/quarkus/pom.xml

<groupId>org.jboss.narayana.lra</groupId>

<parent>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding again the parent pom to inherit the correct failsafe configuration for IT testing

Copy link
Member

@tomjenkinson tomjenkinson Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/quarkus/pom.xml
<properties>
<version.quarkus>3.31.3</version.quarkus>
<!-- currently only defines where to search for the coordinator, it does not change where the coordinator is started -->
<lra.coordinator.host>localhost</lra.coordinator.host>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties are inherited now.

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/tck/pom.xml
<groupId>org.jboss.narayana.lra</groupId>
<artifactId>lra-test-arquillian-extension</artifactId>
<exclusions>
<exclusion>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microprofile-lra-tck uses junit4, so use the vintage engine instead and exclude the not needed junit-jupiter dependencies from lra-test-arquillian

Copy link
Member

@tomjenkinson tomjenkinson Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting, thank you

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
test/tck/pom.xml
</dependency>
<dependency>
<groupId>jakarta.enterprise.concurrent</groupId>
<artifactId>jakarta.enterprise.concurrent-api</artifactId>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concurrent-api dependency is needed since https://github.com/jbosstm/lra/pull/206/changes, we haven't spotted it before because the tests were skipped.

marcosgopen
marcosgopen commented Feb 18, 2026
View reviewed changes
pom.xml
</exclusion>
</exclusions>
</dependency>
<dependency>
Copy link
Member Author

@marcosgopen marcosgopen Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding smallrye-config-core here to fix an issue in lra-test-quarkus-context-test: smallrye-config version in this project is different from the one defined in the quarkus-bom used in lra-test-quarkus-context-test. So there was a mismatch between smallrye-config and smallrye-config-core causing incompatibility in compilation.
Having smallrye-config-core and smallrye-config defined in the root pom we can control that the version of both dependencies is aligned.

@marcosgopen marcosgopen enabled auto-merge (rebase) February 18, 2026 13:28
@marcosgopen
Remove needless exclusions(those dependencies are not included)
3710339
@marcosgopen
Re enable tck testing.
8409eb9 
junit-vintage-engine is needed for compatibility to junit 4 until tck upgrade to junit5
excluding junit5 dependencies from arquillian extension as not compatible with junit4
adding missing concurrent-api dependency needed for tck testing
@marcosgopen
Restore quarkus testing and update README
f1c4e7d 
smallrye-config-core needed to avoid mixing dependency version with quarkus bom
@marcosgopen marcosgopen merged commit 33ba382 into jbosstm:main Feb 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomjenkinson tomjenkinson tomjenkinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcosgopen @tomjenkinson