Fix CompareCommandSettings parameterless constructor issue and improve integration tests #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e integration tests
- Remove 'required' keyword from CompareCommandSettings properties to allow Spectre.Console.Cli to instantiate the class
- Add proper null validation in the Validate method instead
- Fix integration tests to use correct 'compare' command syntax
- Add proper test categories [Trait("Category", "Integration")] to integration tests
- Fix path resolution in FindExecutablePath method (5 levels up instead of 4)
- Replace silent test skipping with proper assertions that fail when prerequisites aren't met
- All 345 tests now pass including 27 integration tests
Fixes the CLI error: 'Could not resolve type CompareCommandSettings - No parameterless constructor defined'
- Replace async process output handling with synchronous ReadToEnd() to avoid StringBuilder issues in CI - Fix path resolution for dotnet run command (5 levels up instead of 4) - Update test assertions to expect exit code 2 (breaking changes detected) as normal for test assemblies - Combine stdout and stderr for error message assertions since validation errors may go to either stream - Add format-specific validation for JSON and Markdown output tests - All 27 integration tests now pass both locally and should pass in CI Fixes CI pipeline failures: - CliWorkflow_WithDifferentOutputFormats_ShouldSucceed JSON test - CliWorkflow_WithNamespaceFiltering_ShouldApplyFilters StringBuilder exception - CliWorkflow_WithNonExistentTargetAssembly_ShouldFail error message assertion - CliWorkflow_WithInvalidOutputFormat_ShouldFail error message assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI was failing with the error:
This was caused by the
requiredkeyword on properties inCompareCommandSettings, which prevents Spectre.Console.Cli from creating instances via the parameterless constructor.Root Cause Analysis
The issue wasn't caught by existing tests because:
CompareCommandSettingsobjects directly using object initializerscomparecommandSolution
Fixed the Constructor Issue
requiredkeyword fromCompareCommandSettingspropertiesValidatemethodExecutemethod since validation ensures non-null valuesImproved Integration Tests
comparecommand syntax[Trait("Category", "Integration")]FindExecutablePathmethod (5 levels up instead of 4)Testing
task test:integrationdotnet run -- compare source.dll target.dllFiles Changed
src/DotNetApiDiff/Commands/CompareCommand.cs- Fixed constructor issuetests/DotNetApiDiff.Tests/Integration/CliWorkflowTests.cs- Fixed CLI syntax and test robustnesstests/DotNetApiDiff.Tests/Integration/ConfigurationWorkflowTests.cs- Added test categoryThis fix ensures the CLI works correctly and that integration tests will catch similar issues in the future.