Fix TypeLoadException warnings and empty Breaking Changes section #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes two issues related to API analysis and HTML report generation:
Changes Made
🔧 Fix TypeLoadException in TypeAnalyzer (#25)
Problem: When analyzing assemblies with custom attributes that reference types that cannot be loaded, the tool throws
TypeLoadExceptionwarnings.Root Cause:
GetCustomAttributes(true)instantiates attribute objects, causing dependency loading issues.Solution:
GetCustomAttributes(true)withGetCustomAttributesData()in bothGetTypeAttributes()andGetMemberAttributes()methodsa.GetType().Nametoa.AttributeType.NameIsCompilerGeneratedAttribute(CustomAttributeData)overload to work with metadataFiles Changed:
src/DotNetApiDiff/ApiExtraction/TypeAnalyzer.cs🔧 Fix Empty Breaking Changes Section (#26)
Problem: HTML reports correctly detect and count breaking changes but the dedicated Breaking Changes section table remains empty.
Root Cause: Scriban template include statement
{{ include "breaking-changes" result.breaking_changes }}was not properly passing data to the template.Solution:
result.breaking_changesdata in the main layout templateFiles Changed:
src/DotNetApiDiff/Reporting/HtmlTemplates/main-layout.scriban🧹 Minor Cleanup
glide-testing/directory to.gitignoreTesting
✅ TypeLoadException Fix:
StackExchange.Redis.dllthat previously threw TypeLoadException warnings✅ Breaking Changes Display Fix:
Benefits
Closes