Skip to content

Fix crash when loading old checkpoints with -reset_iterations 0 flag #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash when loading old checkpoints with -reset_iterations 0 flag #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion train.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,14 @@ if opt.init_from ~= '' then
local checkpoint = torch.load(opt.init_from)
model = checkpoint.model:type(dtype)
if opt.reset_iterations == 0 then
start_i = checkpoint.i
-- Backward compatibility with checkpoints made before
-- reset_iterations was implemented:
if checkpoint.i == nil then
print(string.format('reset_iterations: %s contains no iteration counter',
opt.init_from))
else
start_i = checkpoint.i
end
end
else
model = nn.LanguageModel(opt_clone):type(dtype)
Expand Down