Skip to content

Remove requestjs#37

Open
martinkooij wants to merge 8 commits intojclarke0000:masterfrom
martinkooij:remove-requestjs
Open

Remove requestjs#37
martinkooij wants to merge 8 commits intojclarke0000:masterfrom
martinkooij:remove-requestjs

Conversation

@martinkooij
Copy link

Hi,

  • I removed the dependency on the deprecated "request.js" module in favor of "node-fetch".
  • I rewrote the fetcher towards using async/await; at the same time solving the existing issue of the module at times firing too many requests within a short time period to google when multiple destinations were specified (*).

Feel free to merge.
Martin

(*) Note: basically the existing foreach created a number of callbackfunctions that all fired to Google one after the other. With Debian and node.js now more efficient and my internet better at home it caused the Google API to protest. By using the async await in a loop, we wait for the answer first before going to the next request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant