Merged
Conversation
With this change, the tests run for me on a local build of Python 3.14. There are a lot of failures related to sys.getrefcount() but that seems to be an unrelated issue. Closes jcrist#810. Fixes jcrist#651. Fixes jcrist#795.
Closed
This was referenced Oct 19, 2025
Contributor
Author
Collaborator
|
I just merged that PR, feel free to rebase and add support for 3.14t! |
kumaraditya303
force-pushed
the
thread-safe
branch
from
456f10d to
746c159
Compare
Contributor
Author
done! |
Contributor
Author
|
All green now with 3.14t |
ofek
reviewed
Oct 20, 2025
Collaborator
ofek
left a comment
ofek
left a comment
There was a problem hiding this comment.
I'm still getting ramped up on the codebase so I'm getting assistance from AI here, specifically GPT-5 Thinking (Extended).
ofek
approved these changes
Oct 20, 2025
Collaborator
ofek
left a comment
ofek
left a comment
There was a problem hiding this comment.
Looks great to me, thanks a lot!
manzt
pushed a commit
to marimo-team/msgspec
that referenced
this pull request
Nov 14, 2025
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
manzt
added a commit
to marimo-team/msgspec
that referenced
this pull request
Nov 14, 2025
* Fix crash when TypedDict contains incorrect metadata (jcrist#853) * Fix annotations support on 3.14 (jcrist#852) * Relax all getrefcount tests to allow lower numbers (jcrist#854) * Add 3.14 to CI (jcrist#888) * add free-threading support (jcrist#877) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> * Enable Python 3.14 tests in CI Remove cp314-* from CIBW_TEST_SKIP to allow Python 3.14 tests to run. Previously, 3.14 wheels were built but tests were skipped. --------- Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Miro Hrončok <miro@hroncok.cz> Co-authored-by: Ofek Lev <ofekmeister@gmail.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the thread safety issues in msgspec implementation and add free-threading support as well as making it compatible with 3.14. Python 3.13t support is omitted as it is experimental and has many thread safety issues which won't be fixed.
For fixing compatibility with 3.14, many of the reference counting tests needed be adjusted to account for interpreter now using borrowed reference.
This PR includes #852 should that should be merged first.
edit: resolves #878