Merged
Conversation
Hasnep
force-pushed
the
enable-import-sorting-ruff-rule
branch
2 times, most recently
from
4724e83 to
4f8d090
Compare
Hasnep
force-pushed
the
enable-import-sorting-ruff-rule
branch
from
4f8d090 to
814b728
Compare
Hasnep
force-pushed
the
enable-import-sorting-ruff-rule
branch
from
814b728 to
725d18b
Compare
Contributor
Author
|
I've pushed an updated version of this that should pass the CI checks :) |
Hasnep
force-pushed
the
enable-import-sorting-ruff-rule
branch
from
725d18b to
deb6f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option
tool.ruff.lint.isort.combine-as-importsis enabled in thepyproject.tomlfile, so I assume that import sorting is intended to be on. If this is not wanted, I can open a new PR to remove the config option frompyproject.toml.