Notifications in a distinct topic when starting/ending each file#197
Open
bleporini wants to merge 1 commit intojcustenborder:masterfrom
Open
Notifications in a distinct topic when starting/ending each file#197bleporini wants to merge 1 commit intojcustenborder:masterfrom
bleporini wants to merge 1 commit intojcustenborder:masterfrom
Conversation
Owner
|
Hey @bleporini Well timed PR! I was going to start some work on this very soon. I'm going to merge this into another branch and base my changes on it! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it has been asked a couple of times, here is a proposal to implement notifications when files are processed.
The basic idea is to add some
SourceRecordduring thepollwhen files are opened and closed.I hope it helps, tell me if you see any case where it can make the task fail or if you see required improvement before merging.