Skip to content

Makes the route resolver pattern compatible with MicroPython's re #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Makes the route resolver pattern compatible with MicroPython's re #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MicroWebSrv2/webRoute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def RegisterRoute(handler, method, routePath, name=None) :
if not argName :
raise Exception
argNames.append(argName)
regex += '/([\\w.]*)'
regex += '/([A-Za-z0-9_.]*)'
Copy link

@klitos-giannak klitos-giannak Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion here. Can we add support for whitespace as well? In order to support links like
http://example.com/some page that would be translated from web browsers with a %20
I have tested in CPython to add \s and works but if micropython can't support \w I am not sure how to handle it

else :
regex += '/' + part
regex = re.compile(regex + '$')
Expand Down