Skip to content

fix: observation toContent input param error#3

Open
hikariwo wants to merge 1 commit intojd-opensource:mainfrom
hikariwo:fix_tool_content_bug
Open

fix: observation toContent input param error#3
hikariwo wants to merge 1 commit intojd-opensource:mainfrom
hikariwo:fix_tool_content_bug

Conversation

@hikariwo
Copy link

📝 Description

Brief description of the changes in this PR.

🔄 Type of Change

Please check the applicable options:

  • [√] 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🧪 Test improvement
  • 🚀 Performance improvement
  • 🎨 Style/UI change

🧪 Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • [√] Manual testing completed
  • All existing tests pass

📋 Checklist

  • [√] My code follows the project's style guidelines
  • [√] I have performed a self-review of my own code
  • [√] I have commented my code, particularly in hard-to-understand areas
  • [√] I have made corresponding changes to the documentation
  • [√] My changes generate no new warnings

🔗 Related Issues

Closes #(issue number)

📸 Screenshots (if applicable)

Add screenshots here if UI changes are involved.

📋 Additional Notes

observation.toContent method accepts a parameter "isMultimodalSupported" for adding the tool attachment to the output. But here, the wrong parameter is provided.

@hikariwo
Copy link
Author

cc. @willishz @Aozh @xiaoailiang

Copy link
Contributor

@willishz willishz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants