fix: prevent page crash when creating invalid node connections in agent editor#68
Open
skyvast404 wants to merge 1 commit intomainfrom
Open
fix: prevent page crash when creating invalid node connections in agent editor#68skyvast404 wants to merge 1 commit intomainfrom
skyvast404 wants to merge 1 commit intomainfrom
Conversation
…nt editor - Add defensive checks in onConnect: validate source/target exist, prevent self-loops, and wrap entire handler in try/catch - Wrap BuilderCanvas with ErrorBoundary so graph editor errors don't crash the full page Closes #58 Made-with: Cursor
ruur
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onConnecthandler: check source/target nodes exist, prevent self-loops, and wrap the entire handler in try/catch to gracefully handle unexpected errorsBuilderCanvaswith the project's existingErrorBoundarycomponent so that graph rendering errors are isolated to the canvas area instead of crashing the entire pageCloses #58
Root Cause
The
onConnecthandler inbuilderStore.tshad no validation or error handling. When users created invalid connections between nodes (e.g. connecting incompatible node types), errors thrown bydetermineEdgeTypeAndRouteKeyoraddEdgewould propagate uncaught, causing a React render crash that took down the full page. There was also noErrorBoundaryaround theBuilderCanvascomponent.Test plan
Made with Cursor