perf: use async H2D copy for contiguous shm forward input on npu.#1101
Merged
JimHsiung merged 1 commit intojd-opensource:mainfrom Mar 25, 2026
Merged
perf: use async H2D copy for contiguous shm forward input on npu.#1101JimHsiung merged 1 commit intojd-opensource:mainfrom
JimHsiung merged 1 commit intojd-opensource:mainfrom
Conversation
JimHsiung
requested review from
DongheJin,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an asynchronous Host-to-Device copy for forward inputs on NPU to improve performance. The changes correctly use a stream and non-blocking transfers. My review identifies a potential issue where the underlying shared memory may not be pinned, which could cause the asynchronous copy to behave synchronously and negate the performance benefit. I've provided a suggestion to ensure the data is in pinned memory before the transfer.
XuZhang99
approved these changes
Mar 24, 2026
RobbieLeung
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.