[WIP] feat: refactor layer module to support multiple platforms. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutongxuan
reviewed
Aug 26, 2025
| #include "framework/state_dict/state_dict.h" | ||
|
|
||
| namespace xllm { | ||
| namespace layer { |
There was a problem hiding this comment.
建议这里可能不用加layer这个namespace了，感觉有点多余了
There was a problem hiding this comment.
The namespace layer cannot be deleted yet to prevent naming conflicts among some LayerImpl classes in the model class. Subsequent refactoring will remove the LayerImpl classes from the model and eliminate the namespace layer altogether.
yq33victor
reviewed
Aug 26, 2025
| @@ -0,0 +1,24 @@ | |||
| #pragma once | |||
|
|
|||
| // #ifdef WITH_ASCEND | |||
There was a problem hiding this comment.
nit: delete these comments about WITH_ASCEND :(
a120092009
reviewed
Aug 28, 2025
XuZhang99
changed the title
…tform support and add layer namespace.
…consistency across implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.