feat: enable torch_npu graph mode for Qwen-3 dense with TP support. #325
+2,260
−3,350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of Pending Items for this PRThis PR is a work in progress. The following items need to be completed before it's ready for final review:
|
liutongxuan
changed the title
liutongxuan
changed the title
yingxudeng
force-pushed
the
feat/qwen3_npu_native_main
branch
from
4549991 to
1a5e2f0
Compare
XuZhang99
reviewed
Nov 6, 2025
|
|
||
| torch::Tensor active_tensor(ActivationParams& params) { | ||
| #if defined(USE_NPU) | ||
| return npu::active(params.input); |
There was a problem hiding this comment.
params.output = npu::active(params.input) and we need to choose act_mode
|
|
||
| torch::Tensor fused_layernorm_tensor(FusedLayerNormParams& params) { | ||
| #if defined(USE_NPU) | ||
| return npu::fused_layernorm(params.input, params.weight, params.eps); |
| // for npu | ||
| torch::Tensor seq_lens; | ||
| int num_heads; | ||
| int num_kv_heads; |
There was a problem hiding this comment.
we can get num_heads and num_kv_heads form th shape of query and key.
| namespace xllm { | ||
| namespace layer { | ||
|
|
||
| #if defined(USE_NPU) |
| hidden_size_ = | ||
| context_dim * static_cast<int>(std::pow(spatial_merge_size, 2)); | ||
| ln_q_ = register_module("ln_q", layer::RmsNorm(context)); | ||
| ln_q_ = register_module("ln_q", layer::NpuRmsNorm(context)); |
There was a problem hiding this comment.
why rename RmsNorm to NpuRmsNorm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.