refactor: update causal LM implementations to inherit from LlmForCausalLMImplBase. #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingxudeng
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several causal LM implementations to inherit from a common base class LlmForCausalLMImplBase, which significantly reduces code duplication and improves maintainability. The changes are well-executed across all affected models. I have one piece of feedback regarding a potential bug in the new base class's load_model method, where there's an inconsistency in prefixes used for loading and verifying weights when tie_word_embeddings is enabled. This could lead to silent model loading issues.
yingxudeng
force-pushed
the
feat/model_base
branch
from
96f31b6 to
bc12eb7
Compare
RobbieLeung
reviewed
Jan 5, 2026
yingxudeng
force-pushed
the
feat/model_base
branch
from
bc12eb7 to
fe6b933
Compare
RobbieLeung
approved these changes
Jan 6, 2026
yingxudeng
force-pushed
the
feat/model_base
branch
from
fe6b933 to
5f4512f
Compare
RobbieLeung
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.