refactor: move fused_moe from npu to npu_torch.#956
Open
yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
Open
refactor: move fused_moe from npu to npu_torch.#956yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by moving the fused_moe implementation from the npu directory to npu_torch. This is a logical organization change. However, the PR appears to be incomplete. By moving fused_moe.h, its public include path has changed, but the PR lacks the corresponding updates in files that consume this header. This is likely to cause build failures. Please see the detailed comment.
yingxudeng
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
XuZhang99
approved these changes
Feb 28, 2026
zhang-minchao
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.