feat: add xattention_prefill_reshape_cache kernel.#963
Open
zhang-minchao wants to merge 1 commit intojd-opensource:mainfrom
Open
feat: add xattention_prefill_reshape_cache kernel.#963zhang-minchao wants to merge 1 commit intojd-opensource:mainfrom
zhang-minchao wants to merge 1 commit intojd-opensource:mainfrom
Conversation
zhang-minchao
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new CUDA kernel for prefill_reshape_and_cache, replacing a simpler CPU-based implementation. The new kernel is optimized for performance using vectorized memory access. The PR also includes comprehensive unit tests that cover various tensor layouts, and the necessary build system updates. My review identified one critical issue where input tensor validation is performed after slicing, potentially leading to out-of-bounds memory access. I have provided a code suggestion to correct this validation logic. Once this issue is addressed, the changes look good.
zhang-minchao
force-pushed
the
feat/xattention_prefill_reshape_cache
branch
2 times, most recently
from
6b96a04 to
ff93c78
Compare
XuZhang99
reviewed
Feb 28, 2026
zhang-minchao
force-pushed
the
feat/xattention_prefill_reshape_cache
branch
from
ff93c78 to
482c8fc
Compare
XuZhang99
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.