refactor: optimize speculative decoding pipeline.#974
Open
RobbieLeung wants to merge 1 commit intojd-opensource:mainfrom
Open
refactor: optimize speculative decoding pipeline.#974RobbieLeung wants to merge 1 commit intojd-opensource:mainfrom
RobbieLeung wants to merge 1 commit intojd-opensource:mainfrom
Conversation
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed refactoring of the speculative decoding pipeline. The introduction of spec_input_builder centralizes input construction logic, greatly improving code clarity and maintainability. The EmbeddingCache has been effectively redesigned to better support the specific needs of speculative decoding, and the worker implementations (MTPWorkerImpl, Eagle3WorkerImpl) are now more modular. Overall, these changes represent a substantial improvement to the architecture. I have one critical point regarding a potential crash scenario due to a strong assumption about the output of the rejection sampler.
RobbieLeung
force-pushed
the
refactor/mtp_input
branch
from
5758834 to
b777f96
Compare
XuZhang99
approved these changes
Mar 3, 2026
DongheJin
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait #960