refactor: remove third-party patchs and enforce submodule commit checks.#979
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the third-party dependency initialization logic, making it more robust by checking whether initialization is necessary before running it. The changes are mostly in utils.py, with corresponding adjustments in setup.py. The new logic checks submodule status, patch application status, and the presence of required libraries. While the overall logic is a good improvement, there are some critical issues in the implementation where utility functions terminate the program using exit(1) instead of propagating errors to their callers. This makes the code less predictable, reusable, and testable. I've left comments with suggestions to fix these issues by replacing exit(1) with more appropriate error handling mechanisms.
fd3f75e to
902f1c1
Compare
b07ac4d to
e90e6f0
Compare
9391f72 to
7f64789
Compare
7f64789 to
effa53f
Compare
No description provided.