refactor: refine fused_moe implementation.#994
Open
yq33victor wants to merge 1 commit intojd-opensource:mainfrom
Open
refactor: refine fused_moe implementation.#994yq33victor wants to merge 1 commit intojd-opensource:mainfrom
yq33victor wants to merge 1 commit intojd-opensource:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request removes the fused_moe.cpp and fused_moe.h files from the common layers. These files contained placeholder implementations that would result in a fatal error if invoked, indicating they were intended for unsupported backends and were superseded by backend-specific implementations. This refactoring improves code clarity and reduces the codebase by eliminating dead code.
yq33victor
force-pushed
the
dev/delete_code
branch
from
23d9396 to
5782ee2
Compare
yq33victor
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan and
walsonyang
as code owners
XuZhang99
previously approved these changes
Mar 4, 2026
yq33victor
force-pushed
the
dev/delete_code
branch
from
5782ee2 to
324938d
Compare
yq33victor
changed the title
yq33victor
force-pushed
the
dev/delete_code
branch
2 times, most recently
from
48328ca to
966303c
Compare
Signed-off-by: yq33victor <pengtao.156@jd.com>
yq33victor
force-pushed
the
dev/delete_code
branch
from
966303c to
2b369f7
Compare
XuZhang99
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.