Open
Conversation
Simplify and fixup the PixFmt trait.
An affine basis, or frame, consists of basis vectors and an origin point. Rename the existing from_basis to from_linear.
Was already added to Spherical and SphericalVec earlier.
This sets the r component to 1, which is a more reasonable default. Make the existing Default for Vector only apply to those with Real basis to avoid overlapping impls.
Quads are subdivided into tris by the parser.
* Return full item name in UnrecognizedItem * Recognize and ignore additional valid item types.
Use Buf<Color3> rather than Colorbuf in integration test.
This is not automatic now that the workspace is non-virtual. Also fix some minor Clippy warnings and add missing dependency version numbers to demos/wasm/Cargo.toml.
Should check what's needed for writing one impl for all Affine. Probably AsRef<[T]> or From or similar to get the components.
jdahlstrom
force-pushed
the
dev
branch
3 times, most recently
from
5e9a307 to
1ebf545
Compare
jdahlstrom
force-pushed
the
dev
branch
2 times, most recently
from
8edeca7 to
7b1d3df
Compare
jdahlstrom
force-pushed
the
dev
branch
2 times, most recently
from
024a425 to
cce0d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.