Draft
Conversation
Should check what's needed for writing one impl for all Affine. Probably AsRef<[T]> or From or similar to get the components.
Mat4, Mat3, and Mat2 are now always real-to-real and take two optional basis parameters and an optional dimension. For projection matrices, new alias ProjMat3 is used; it goes well with ProjVec3.
* for [] for convenient sampling from slices with replacement * for &T where T: Distrib to support [] and remove need to clone * for Range<T> where Uniform<T>: Distrib, as uniform is the 95% use case
For years the matrices have accidentally been left-handed, not right-handed as intended. This stuff is tricky...
* linear() returns the linear 3x3/2x2 submatrix. * translation() returns the affine translation vector. Also combine two Mat4 impl blocks.
Avoids having to explicitly import the trait.
Recursively subdivided from an icosahedron.
Currently implemented for types whose diff type is a vector. Original approximate() method renamed to approximate_with().
jdahlstrom
force-pushed
the
new-pixfmts
branch
from
7d70dca to
3d0e0bf
Compare
jdahlstrom
force-pushed
the
dev
branch
2 times, most recently
from
8edeca7 to
7b1d3df
Compare
jdahlstrom
force-pushed
the
dev
branch
2 times, most recently
from
024a425 to
cce0d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.