Change As(Mut)Slice2 type parameter to an associated type#341
Merged
jdahlstrom merged 1 commit intodevfrom Jan 1, 2026
Merged
Conversation
This is a better match and allows making various Target impls generic over any pixel format. The custom Framebuf type for SDL2 could be removed.
jdahlstrom
force-pushed
the
slice2-assoc-type
branch
from
2317f29 to
4d70dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a better match and allows making various Target impls generic over any pixel format. The custom Framebuf type for SDL2 could be removed.