4935 test refactoring element sidenav #5375

EvgStep · 2024-01-24T09:07:47Z

No description provided.

4935_Test-refactoring-element-Sidenav

pnatashap

не поверю, что с описанием самих классов все хорошо и ничего менять не надо

pnatashap · 2024-01-24T14:53:26Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java

    public static final String MODE = "mode";
    public static final String SIDE = "side";

    @BeforeMethod(alwaysRun = true)


Suggested change

@BeforeMethod(alwaysRun = true)

@BeforeClass(alwaysRun = true)

заменил

pnatashap · 2024-01-24T14:58:14Z

jdi-light-angular-tests/src/main/java/io/github/com/pages/SideNavPage.java

+    public static Button toggleFixedSideNav;
+
+    @UI("#fixed-position .mat-sidenav-content mat-form-field input[formcontrolname='top']")
+    public static UIElement topGap;


не должно быть UIElement на странице

убрал все UIElment

pnatashap · 2024-01-24T15:01:02Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java

+
+        backDropToggle.click();
+        sidenavBackdropDrawer.is().displayed();
+        sidenavBackdropDrawer.has().cssClass("mat-drawer-end");


не нужно проверять наличие css классов, этот функционал прекрасно работает
если класс что-то значит - должен быть в описании класса

исправил

pnatashap · 2024-01-24T15:10:13Z

почему прогон автотестов не запустился, тоже не понятно

pnatashap · 2024-01-26T14:30:26Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/SideNav.java

+    }

    @JDIAction("Get '{name}' side nav")
    public UIElement getSideNav() {


не понятно: в классе SideNav у нас есть метод, который просит SideNav по какому-то индексу и получает UIElement.
явно нужно переделать

исправил

pnatashap · 2024-01-26T14:32:51Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java


        toggleFixedSideNav.click();
        fixedPosition.base().timer().wait(() -> fixedPosition.visualValidation(".mat-sidenav-content"));
        fixedPosition.getSideNav().has().attr(STYLE, "top: 100px; bottom: 100px; box-shadow: none; visibility: " +


не надо проверять style, это не стабильно и базовый функционал, который проверяется в html пакете

все еще на месте

pnatashap · 2024-01-26T14:34:00Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java

+            "100px;");

        toggleFixedSideNav.click();
        fixedPosition.base().timer().wait(() -> fixedPosition.visualValidation(".mat-sidenav-content"));


очень плохо, что нам нужно использовать классы в тестах, значит, что не сделан метод

исправил

pnatashap · 2024-01-26T14:34:42Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java

        toggleExtraText.click();
        autoSizeSideNav.getMatDrawer().has().text(containsString("Toggle extra text"));
-        autoSizeSideNav.getMatDrawerContent().has().attr(STYLE, "margin-left: 294px;");
+        autoSizeSideNav.getMatDrawerContent().has().attr(STYLE, "margin-left: 303px;");


не надо вообще это проверять, оно еще и на разных разрешениях экранов может поехать

pnatashap

Full component review is required.
Only components from the documentation should be described

pnatashap · 2024-02-02T03:08:00Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+    @JDIAction("Get '{name}' side nav  by '{0}' position value")
+    public SideNav getSideNav(String position) {
+        UIElement element = null;
+        for (UIElement e : getSideNavItems()) {


it is good to know how to implement it via streams

pnatashap · 2024-02-02T03:09:15Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+
+    @JDIAction("Get '{name}' side nav content")
+    public UIElement getEvents() {
+        return getContent().find(".example-events");


it is obvious that this is a part of example site only.

pnatashap · 2024-02-02T03:17:07Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+    }
+
+    @JDIAction("Get '{name}' side nav content")
+    public WebList getResponsiveResults() {


This method is not generic, there is no p description in component description

а что именно исправлено?
элемент p не входит в описание sidenav, это просто какое-то содержимое, которое может быть другим, поэтому тут его быть не может

pnatashap · 2024-02-02T03:18:37Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/SideNav.java


    @JDIAction("Get '{name}' side nav items")
    private WebList getSideNavItems() {
        return this.finds(".mat-sidenav");


How it is possible to have sidenav inside sidenav?

pnatashap

почему так много изменений отмечено исправлеными и никаких изменений нет?

pnatashap · 2024-02-17T00:55:42Z

jdi-light-angular-tests/src/main/java/io/github/com/enums/ConfigurableMode.java

+
+    public String getMode() {
+        return mode;
+    }


обычно еще делают метод получения Enum по строковому значению

pnatashap · 2024-02-17T00:57:16Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+    }
+
+    @JDIAction("Get '{name}' side nav content")
+    public WebList getResponsiveResults() {


а что именно исправлено?
элемент p не входит в описание sidenav, это просто какое-то содержимое, которое может быть другим, поэтому тут его быть не может

pnatashap · 2024-02-17T00:58:43Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+    }
+
+    @JDIAction("Get '{name}' side nav content")
+    public UIElement getContent() {


в интро к проекту есть часть про наименования - там написано, что мы минимизируем количество методов с get***, т.е. пишем их в случае крайней необходимости

pnatashap · 2024-02-17T01:01:37Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+
+    @JDIAction("Get '{name}' side nav  by '{0}' position value")
+    public SideNav getSideNav(String position) {
+        String notFoundMessage = String.format(ATTRIBUTE_NOT_FOUND_MESSAGE, POSITION, position);


а зачем собирать строку, которая может и не понадобится?

pnatashap · 2024-02-17T01:25:00Z

...ht-angular/src/main/java/com/epam/jdi/light/angular/elements/composite/SideNavContainer.java

+    private static final String POSITION = "position";
+    private static final String ATTRIBUTE_NOT_FOUND_MESSAGE = "Element with attribute %s %s not found";
+
+    private Predicate<UIElement> attributeMatches(String attributeName, String attributeValue) {


используется в итоге в одном месте, зачем он тут?

pnatashap · 2024-02-17T01:25:25Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/SideNaveAssert.java

+import static com.epam.jdi.light.asserts.core.SoftAssert.jdiAssert;
+import static java.lang.String.format;
+
+public class SideNaveAssert extends UIAssert<SideNaveAssert, SideNav> implements ITextAssert<SideNaveAssert> {


Suggested change

public class SideNaveAssert extends UIAssert<SideNaveAssert, SideNav> implements ITextAssert<SideNaveAssert> {

public class SideNavAssert extends UIAssert<SideNaveAssert, SideNav> implements ITextAssert<SideNaveAssert> {

pnatashap · 2024-02-17T01:28:01Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/SideNavContainerAssert.java

+    private static final String LOCATION_ERROR_MESSAGE = "SideNavSection with location %s isn't on the right side";
+
+    @JDIAction(value = "Assert that '{name}' has section with location '{0}' on the right side", isAssert = true)
+    public SideNavContainerAssert sideNavSectionOnTheRight(Point locationOfSection) {


зачем нам проверять, что-то по координатам?

pnatashap · 2024-02-17T01:28:22Z

...-angular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/SideNavTests.java


        toggleFixedSideNav.click();
        fixedPosition.base().timer().wait(() -> fixedPosition.visualValidation(".mat-sidenav-content"));
        fixedPosition.getSideNav().has().attr(STYLE, "top: 100px; bottom: 100px; box-shadow: none; visibility: " +


все еще на месте

4935_Test-refactoring-element-Sidenav2

21d3a78

4935_Test-refactoring-element-Sidenav

EvgStep assigned spbqaru Jan 24, 2024

EvgStep changed the base branch from master to angular_rework_development January 24, 2024 09:09

pnatashap requested a review from spbqaru January 24, 2024 14:56

pnatashap unassigned spbqaru Jan 24, 2024

pnatashap requested changes Jan 24, 2024

View reviewed changes

EvgStep requested a review from pnatashap January 26, 2024 08:39

4935_Test-refactoring-element-Sidenav3

ac9d151

EvgStep force-pushed the 4935_Test-refactoring-element-Sidenav branch from e3e77f3 to ac9d151 Compare January 26, 2024 10:40

pnatashap requested changes Jan 26, 2024

View reviewed changes

4935_Test-refactoring-element-Sidenav4

7795a4b

EvgStep requested a review from pnatashap January 31, 2024 13:41

pnatashap requested changes Feb 2, 2024

View reviewed changes

4935_Test-refactoring-element-Sidenav5

5c94038

EvgStep requested a review from pnatashap February 6, 2024 08:52

pnatashap requested changes Feb 17, 2024

View reviewed changes

pnatashap requested a review from vklonin February 17, 2024 01:30

	@BeforeMethod(alwaysRun = true)
	@BeforeClass(alwaysRun = true)

	public class SideNaveAssert extends UIAssert<SideNaveAssert, SideNav> implements ITextAssert<SideNaveAssert> {
	public class SideNavAssert extends UIAssert<SideNaveAssert, SideNav> implements ITextAssert<SideNaveAssert> {

4935 test refactoring element sidenav #5375

Are you sure you want to change the base?

4935 test refactoring element sidenav #5375

Uh oh!

Conversation

EvgStep commented Jan 24, 2024

Uh oh!

pnatashap left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pnatashap commented Jan 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pnatashap left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pnatashap left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!