#4908: Tests refactoring: Form field element #5391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnatashap
requested changes
Feb 4, 2024
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/FormField.java
Outdated
Show resolved
Hide resolved
| String currentXpath = "(" + matFormFieldPrefix + containerAttribute + "])[" + index + "]"; | ||
| try { | ||
| getDriver().findElement(By.xpath(currentXpath + "//input")); | ||
| core().find(By.cssSelector("input")).get(); |
Contributor
There was a problem hiding this comment.
- не нужна эта эвристика, должен быть FormField<TextArea> если там длинный текст и другие поля (для них надо интерфейс сделать, чтобы можно было расширять)
- вместо try catch существует метод IsExists
Contributor
|
@kira-vlsv давай начнем с того, что ты поймешь, как исправлять ошибки автопроверки, например |
pnatashap
requested changes
Apr 6, 2024
...ngular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/FormFieldTests.java
Outdated
Show resolved
Hide resolved
...ngular-tests/src/test/java/io/github/epam/angular/tests/elements/complex/FormFieldTests.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/interfaces/IFormField.java
Outdated
Show resolved
Hide resolved
pnatashap
requested changes
Apr 24, 2024
| @JDIAction("Get icon with '{name}'") | ||
| default UIElement icon() { | ||
| WebElement element = core().find(By.xpath("//mat-icon/ancestor::button")); | ||
| return new UIElement(element); |
Contributor
There was a problem hiding this comment.
find(...) возвращает UIElement, зачем еще что-то?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored tests for FormFieldTests
Added new ones to cover the following features:
appearance: 'fill' | 'outline'
floatLabel: 'always' | 'auto'
hideRequiredMarker: boolean
disabled: boolean
empty: boolean
required: boolean
shouldLabelFloat: boolean