This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Fix for ruby bug when using 地 in sentences and config bug#136
Open
jay-pee wants to merge 4 commits intojdlorimer:masterfrom
Open
Fix for ruby bug when using 地 in sentences and config bug#136jay-pee wants to merge 4 commits intojdlorimer:masterfrom
jay-pee wants to merge 4 commits intojdlorimer:masterfrom
Conversation
Author
|
Added a solution for issue #127 Sorry this was kind of automatically added to the older PR. Should have reset my git repo to the original state and then submit a new PR. |
jay-pee
changed the title
Author
|
I overlooked some use of the deleted class, which now leads to errors. Have to investigate further. |
Also remove unecessary config.save statement
Author
|
Had to reintroduce |
|
In case no one saw this: in that screenshot, Color blue 说 shows as Pinyin blue shuì and Bopomofo red ㄕㄨㄛ (shuō) instead of blue ㄕㄨㄟˋ (shuì). I'm interested in what the Ruby (Bopomofo) field looks like, whether 说 is in red-on-blue or just one color. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the comment at #134 I expanded a bit on the problem.
You can see that the word separation is wrong: 地问 (dewen) is written as one word. (or is it correct?)
Maybe the separation has to be improved...