-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/handle local record type markup #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles to properly convey the type of recipe being built
… creatign dedicated recordtypeservice
…lues and associated mocks
…icklist values taht are not avialabe for a record type
…ct to parse through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Before this update, faker values associated with picklist, dependent picklists, and multipicklists were based upon each available value found in the field's xml markup.
In the scenario of a real Salesforce org, these fields and associated options in picklist values are adjustable through the use of Record Types.
This update introduces logic to parse an object's expected "recordTypes" directory. If one exists in the source code for an object, a record type to available picklist values map will be used to adjust what shows up as the possible faker values within the generated recipe.
These record type driven faker values introduce a new "TODO" for the user as the user has to choose what set of Record Type value for the field and ensure any other record type associated TODO's are consistent with a chosen RecordTypeId.
This PR does introduce a "RecordTypeId" field if "recordTypes" directory exists but provides RecordType Developer Names. If using Workbench or postman to leverage the data set collection api files, until logic is introduced to query a target org before applying a data set, this RecordTypeId value will need the hardcoded record type ids of an expected org.
What does this PR do?
Dependent Picklist Record Type options example:
Multiselect Picklist and standard Picklist Record Type options example:
Type of Change
How Has This Been Tested?
Test Details
[Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration]
Checklist
Additional Notes
[Add any other context, screenshots, or relevant information about the PR here]
Reviewers
@mention-team-members-or-specific-reviewers