Skip to content

Conversation

@jdschleicher
Copy link
Owner

@jdschleicher jdschleicher commented Feb 25, 2025

Motivation and Context

This change represents a bug fix reported here: #11

What does this PR do?

When processing xml markup to generate a "faker" value, there can be a dependency on record type markup for the associated object of the field being processed.

The bug stemmed from an unchecked assumption that a dependent picklist field WOULD NOT exist in the record type markup. This caused an error in downstream logic that expected the record type xml to exist when generating the faker value.

This bug would also occur even in the most basic scenario of a record type file not existing at all and a dependent picklist would try to find associated information in record type markup that never existing to begin with.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (please describe):

How Has This Been Tested?

  • Tested on Windows
  • Tested on macOS
  • Tested on Linux
  • Added new unit tests
  • Updated existing tests

Test Details

  • tested with scenarios of no record types for object, record type without markup of controlling field api name, and original logic for record type xml markup with expected controlling field api value set info

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

n/a

Reviewers

n/a

…ield doesn't include a controlling value, we want to capture whether that record type markup has the field being processed referenced to begin with in its valueSet markup
@jdschleicher jdschleicher merged commit 77187e2 into main Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant