-
-
Notifications
You must be signed in to change notification settings - Fork 28
Extract server concept from current complicated msg-io interaction
#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
The two hash tables are literally same. It seems |
|
Now only leave hover.rkt has bug, I will check how to fix it tomorrow |
Yes, I think we should remove |
|
ok, hover is not always failed, because the refactoring we make test be fast enough, doc analyze might not complete in this case…… |
|
success case: failed case: |
|
I don't see reasonable fix for The test client still not prefect, in the future we should gradually change it (e.g. |
msg-io interaction
| (define current-server #f) | ||
| (define (set-current-server! s) | ||
| (set! current-server s)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the best way, but parameterize cannot make check-syntax.rkt use this.
Maybe the complete refactoring should put every methods into server%?
1. include server request we use async-channel 2. main loop will take message from async-channel and flush it via stdio 3. fix tests
introduce notification-channel for this case misc: - use rackunit in hover.rkt - use rackunit
Extract server concept from current complicated
msg-iointeraction, so we don't need to use message flushing in testing.chchchtests/client.rktwill not create subprocess but interact with server via async channel now (no needmsg-io)main.rktto work with server abstraction (now main loop is the only place flush message)resolve #157